feat(ebe): hide recovery api under non recovery mode#91
Merged
pranavjain97 merged 2 commits intomasterfrom Jul 25, 2025
Merged
Conversation
cpatino-intive
requested review from
Copilot,
mohammadalfaiyazbitgo and
pranavjain97
There was a problem hiding this comment.
Pull Request Overview
This PR adds a safety mechanism to ensure recovery-related API endpoints are only accessible when the server is running in recovery mode. It introduces a configuration check that throws an error when recovery operations are attempted without the proper mode enabled.
- Added
checkRecoveryModeutility function to validate recovery mode configuration - Integrated recovery mode checks in recovery transaction handlers
- Updated test configurations to include recovery mode flag
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/api/enclaved/utils.ts | Added checkRecoveryMode function to validate recovery mode configuration |
| src/api/enclaved/handlers/signEddsaRecoveryTransaction.ts | Added recovery mode check at the start of the handler |
| src/api/enclaved/handlers/recoveryMultisigTransaction.ts | Added recovery mode check and updated imports |
| src/tests/api/enclaved/signMpcRecoveryTransaction.test.ts | Added recoveryMode: true to test configuration |
| src/tests/api/enclaved/recoveryMusigEth.test.ts | Added recoveryMode: true to test configuration |
| src/tests/api/enclaved/recoveryMultisigTransaction.test.ts | Added recoveryMode: true to test configuration |
pranavjain97
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASKS: WP-5319