fix(mbe): fix validation params for recovery#95
Merged
pranavjain97 merged 2 commits intomasterfrom Jul 30, 2025
Merged
Conversation
pranavjain97
force-pushed
the
WP-5454-fix-btc-recovery-validation
branch
from
31ba2ce to
fdc1b13
Compare
pranavjain97
force-pushed
the
WP-5454-fix-btc-recovery-validation
branch
from
fdc1b13 to
a98af04
Compare
alextse-bg
previously approved these changes
Jul 30, 2025
| return; | ||
| } | ||
|
|
||
| if (isUtxoCoin(sdkCoin)) { |
| } | ||
|
|
||
| if (isUtxoCoin(sdkCoin)) { | ||
| if (params.solanaRecoveryOptions || params.evmRecoveryOptions) { |
Contributor
There was a problem hiding this comment.
I thought you are going to change this to !params.utxoReocveryOptions
pranavjain97
force-pushed
the
WP-5454-fix-btc-recovery-validation
branch
from
266874f to
2cb0934
Compare
pranavjain97
changed the title
pranavjain97
force-pushed
the
WP-5454-fix-btc-recovery-validation
branch
from
2cb0934 to
4030a48
Compare
pranavjain97
force-pushed
the
WP-5454-fix-btc-recovery-validation
branch
from
4030a48 to
d316e35
Compare
Comment on lines
+75
to
+79
| if (!params.solanaRecoveryOptions) { | ||
| throw new ValidationError('Solana recovery options are required for EdDSA coin recovery'); | ||
| } | ||
| } else if (isEcdsaCoin(sdkCoin)) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think this is correct, you can broadcast a sol recovery transaction without a durable nonce.
Comment on lines
+101
to
+104
| if (!isMpcRecovery && isEthLikeCoin(sdkCoin)) { | ||
| // Non-ECDSA ETH-like coins need evmRecoveryOptions for standard recovery | ||
| if (!params.evmRecoveryOptions) { | ||
| throw new ValidationError('EVM recovery options are required for ETH-like coin recovery'); |
Contributor
There was a problem hiding this comment.
evmRecoveryOptions this should be optional no?
alextse-bg
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5454