Fix for auth error and README updates#2
Open
deadrich wants to merge 3 commits intoBoingBoing:masterfrom
deadrich:master
Open
Fix for auth error and README updates#2deadrich wants to merge 3 commits intoBoingBoing:masterfrom deadrich:master
deadrich wants to merge 3 commits intoBoingBoing:masterfrom
deadrich:master
Conversation
Added additional information about setting up Google API key and required instructions about adding service account to Google Analytics.
$profileID was hardcoded. Have changed this to use the GOOGLE_ANALYTICS_PROFILE_ID as defined in setup.php
Author
|
There was a problem with the profile ID being hardcoded. This fixes that issue. Also removed the line sending the message to Slack #analytics channel as it was throwing an error when the analytics channel did not exist. |
Removed $cred->sub = GOOGLE_USER_EMAIL;
deadrich
changed the title
|
This is good, please merge: it works and finally the REAME.md contains enough information! Obv. it could be a bit more cleaned up, but I got this finally working and I am happy 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional information about setting up Google API key and
required instructions about adding service account to Google Analytics.