Conversation
nsingh-branch
approved these changes
Nov 27, 2024
Contributor
nsingh-branch
left a comment
nsingh-branch
left a comment
There was a problem hiding this comment.
Some UI/UX nit, but overall looks good and a huge improvement over the existing app!
bredmond5
force-pushed
the
ENGMT-1881-2
branch
from
4f1a02e to
0f199c2
Compare
wpinho-branch
added a commit
that referenced
this pull request
Jan 20, 2026
Changes: - OLD API now uses Branch.application(_:open:options:) for URL schemes (the actual AppDelegate method that would cause double-open) - OLD API now uses Branch.continue(userActivity) for Universal Links - Clear step-by-step logging showing: - Step 1: initSession(launchOptions: nil) → OPEN #1 - Step 2: application(_:open:) → OPEN #2 (bug) - NEW API uses BranchScene.initSession(with:) which handles everything in a single OPEN request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holy rebase hell. Swift generates so many binary files that the conflicts were insane. I dont even really understand what i ended up doing. There still is a problem on BranchLinkSimulator.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
that i dont know how to fix
Anyways, adds: