find_speaker_clashes: avoid crash without a talk or a page#768
Merged
drnlm merged 1 commit intoCTPUG:masterfrom Apr 16, 2026
Merged
find_speaker_clashes: avoid crash without a talk or a page#768drnlm merged 1 commit intoCTPUG:masterfrom
drnlm merged 1 commit intoCTPUG:masterfrom
Conversation
If a user creates a schedule item and adds them to the schedule before
associating a talk or a page, this causes a crash, because `speakers`
will not be defined.
UnboundLocalError: cannot access local variable 'speakers' where it
is not associated with a value
terceiro
force-pushed
the
fix-crash-find-speaker-clashes
branch
from
02c4ecb to
ac897ca
Compare
Contributor
Author
|
The model validation should also probably disallow saving a schedule item without either a talk or a page. |
drnlm
approved these changes
Apr 16, 2026
Member
|
Thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user creates a schedule item and adds them to the schedule before associating a talk or a page, this causes a crash, because
speakerswill not be defined.