`SortFieldsByName` does not appear to work for filter/sort input types.

[stand-sure]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

SortFieldsByName does not appear to work for filter/sort input types.

Steps to reproduce

1. IRequestExecutorBuilder builder = services.AddGraphQLServer() .ModifyOptions(options => { options.SortFieldsByName = true; })
2. Saving the schema and compare.

Relevant log output

No response

Additional Context?

Product

Hot Chocolate

Version

12.5.0

[sgabler-solytic]

I think we have the same or similar issue.

I set a breakpoint in CreateSchemaAsync (RequestExecutorResolver.cs) in version 12.7.0-preview.41

At first the order seems correct, but then I don't understand the logic anymore.

How about doing a final "SortByName" after all types have been initialized? Or is there maybe a special reason why the order is how it is? @PascalSenn @michaelstaib

[michaelstaib]

A dictionary has no order in .NET

[sgabler-solytic]

Thanks for the feedback. This was more an attempt to find the root cause, but seems that this was not helpful. Sorry. 😅

Here is a screenshot of a snapshot that we took from our GraphQL schema.

I collapsed everything that is not relevant (dark grey). But I was assuming that the order of the types would be alphabetical, but in the screenshot you can see that this is not the case.

This snapshot was taken with the following introspection query:

query IntrospectionQuery {
  __schema {
    queryType {
      name
    }
    mutationType {
      name
    }
    subscriptionType {
      name
    }
    types {
      ...FullType
    }
    directives {
      name
      description
      locations
      args {
        ...InputValue
      }
    }
  }
}

fragment FullType on __Type {
  kind
  name
  description
  fields(includeDeprecated: true) {
    name
    description
    args {
      ...InputValue
    }
    type {
      ...TypeRef
    }
    isDeprecated
    deprecationReason
  }
  inputFields {
    ...InputValue
  }
  interfaces {
    ...TypeRef
  }
  enumValues(includeDeprecated: true) {
    name
    description
    isDeprecated
    deprecationReason
  }
  possibleTypes {
    ...TypeRef
  }
}

fragment InputValue on __InputValue {
  name
  description
  type {
    ...TypeRef
  }
  defaultValue
}

fragment TypeRef on __Type {
  kind
  name
  ofType {
    kind
    name
    ofType {
      kind
      name
      ofType {
        kind
        name
        ofType {
          kind
          name
          ofType {
            kind
            name
            ofType {
              kind
              name
              ofType {
                kind
                name
              }
            }
          }
        }
      }
    }
  }
}

My assumption was that the order of those types would be alphabetical, because we enabled the following settings:

.ModifyOptions(x => x.SortFieldsByName = true)  // Sort schema fields alphabetically

I guess I am misunderstanding the upgrade guide here: https://chillicream.com/docs/hotchocolate/api-reference/migrate-from-10-to-11#field-ordering

[michaelstaib]

It’s about field ordering not type ordering. What is the value for sorting these types? A tool can do this on the client side.

[sgabler-solytic]

Ok, then I definitely misunderstood it. sorry about that. I probably accidentally hijacked @stand-sure 's issue then 😅

Originally I thought that this flag would SortFieldsByName apply for the introspection query, for example. In my case we had big changes when comparing the schema snapshot from v10 to v12. The order of the types had changed quite a bit.

But you are right, I can probably solve this by always sorting those types on the client side first. I'll try that now.