Skip to content

Fixed parser locations #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 12 commits into from
Mar 9, 2026
Merged

Fixed parser locations #7189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c9e1215
Fixed parser locations
glen-84 Jun 24, 2024
6920c00
Merge branch 'main' into gai/fix-parser-locations
glen-84 Sep 10, 2024
7b443c1
Merge branch 'main' into gai/fix-parser-locations
glen-84 Oct 1, 2024
38ca44c
Merge branch 'main' into gai/fix-parser-locations
glen-84 Jul 10, 2025
031fcf8
Updated snapshot
glen-84 Jul 10, 2025
2c775cd
Merge branch 'main' into gai/fix-parser-locations
glen-84 Oct 17, 2025
18705d6
Updated snapshot
glen-84 Oct 17, 2025
1d40f61
Merge branch 'main' into gai/fix-parser-locations
glen-84 Feb 17, 2026
955d972
Merge main into pr-7189
michaelstaib Mar 9, 2026
783d0f9
Update missing parser snapshot and drop unrelated docs changes
michaelstaib Mar 9, 2026
3b70dff
Revert accidental docs formatting from merge
michaelstaib Mar 9, 2026
b72b525
Merge branch 'main' into gai/fix-parser-locations
michaelstaib Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...__/IntrospectionRuleTests.IntrospectionNotAllowed_Schema_Field_Custom_MessageFactory.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"Kind": "Name",
"Location": {
"Start": 6,
"End": 16,
"End": 14,
"Line": 2,
"Column": 5
},
Expand Down
2 changes: 1 addition & 1 deletion src/HotChocolate/Language/src/Language.Utf8/Utf8GraphQLParser.Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ public ref partial struct Utf8GraphQLParser
private NameNode ParseName()
{
var start = Start();
var name = ExpectName();
var location = CreateLocation(in start);
var name = ExpectName();

return new NameNode
(
Expand Down
8 changes: 4 additions & 4 deletions ...ge/test/Language.Tests/Parser/__snapshots__/DirectiveParserTests.ParseQueryDirective.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"Kind": "Name",
"Location": {
"Start": 25,
"End": 29,
"End": 28,
"Line": 2,
"Column": 25
},
Expand All @@ -59,7 +59,7 @@
"Kind": "Name",
"Location": {
"Start": 30,
"End": 38,
"End": 37,
"Line": 2,
"Column": 30
},
Expand All @@ -83,7 +83,7 @@
"Kind": "Name",
"Location": {
"Start": 40,
"End": 49,
"End": 47,
"Line": 2,
"Column": 40
},
Expand Down Expand Up @@ -116,7 +116,7 @@
"Kind": "Name",
"Location": {
"Start": 70,
"End": 93,
"End": 75,
"Line": 3,
"Column": 21
},
Expand Down
4 changes: 2 additions & 2 deletions ...e.Tests/Parser/__snapshots__/GraphQLParserSyntaxTests.Parse_FieldNode_From_ByteArray.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"Kind": "Name",
"Location": {
"Start": 4,
"End": 6,
"End": 5,
"Line": 1,
"Column": 5
},
Expand Down Expand Up @@ -44,7 +44,7 @@
"Kind": "Name",
"Location": {
"Start": 0,
"End": 4,
"End": 3,
"Line": 1,
"Column": 1
},
Expand Down
4 changes: 2 additions & 2 deletions ...uage.Tests/Parser/__snapshots__/GraphQLParserSyntaxTests.Parse_FieldNode_From_Reader.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"Kind": "Name",
"Location": {
"Start": 4,
"End": 6,
"End": 5,
"Line": 1,
"Column": 5
},
Expand Down Expand Up @@ -44,7 +44,7 @@
"Kind": "Name",
"Location": {
"Start": 0,
"End": 4,
"End": 3,
"Line": 1,
"Column": 1
},
Expand Down
4 changes: 2 additions & 2 deletions ...uage.Tests/Parser/__snapshots__/GraphQLParserSyntaxTests.Parse_FieldNode_From_String.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"Kind": "Name",
"Location": {
"Start": 4,
"End": 6,
"End": 5,
"Line": 1,
"Column": 5
},
Expand Down Expand Up @@ -44,7 +44,7 @@
"Kind": "Name",
"Location": {
"Start": 0,
"End": 4,
"End": 3,
"Line": 1,
"Column": 1
},
Expand Down
2 changes: 1 addition & 1 deletion ...s/Parser/__snapshots__/GraphQLParserSyntaxTests.Parse_ObjectValueNode_From_ByteArray.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"Kind": "Name",
"Location": {
"Start": 2,
"End": 4,
"End": 3,
"Line": 1,
"Column": 3
},
Expand Down
2 changes: 1 addition & 1 deletion ...ests/Parser/__snapshots__/GraphQLParserSyntaxTests.Parse_ObjectValueNode_From_Reader.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"Kind": "Name",
"Location": {
"Start": 2,
"End": 4,
"End": 3,
"Line": 1,
"Column": 3
},
Expand Down
2 changes: 1 addition & 1 deletion ...ests/Parser/__snapshots__/GraphQLParserSyntaxTests.Parse_ObjectValueNode_From_String.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"Kind": "Name",
"Location": {
"Start": 2,
"End": 4,
"End": 3,
"Line": 1,
"Column": 3
},
Expand Down
4 changes: 2 additions & 2 deletions .../Parser/__snapshots__/GraphQLParserSyntaxTests.Parse_SelectionSetNode_From_ByteArray.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"Kind": "Name",
"Location": {
"Start": 6,
"End": 8,
"End": 7,
"Line": 1,
"Column": 7
},
Expand Down Expand Up @@ -53,7 +53,7 @@
"Kind": "Name",
"Location": {
"Start": 2,
"End": 6,
"End": 5,
"Line": 1,
"Column": 3
},
Expand Down
4 changes: 2 additions & 2 deletions ...sts/Parser/__snapshots__/GraphQLParserSyntaxTests.Parse_SelectionSetNode_From_Reader.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"Kind": "Name",
"Location": {
"Start": 6,
"End": 8,
"End": 7,
"Line": 1,
"Column": 7
},
Expand Down Expand Up @@ -53,7 +53,7 @@
"Kind": "Name",
"Location": {
"Start": 2,
"End": 6,
"End": 5,
"Line": 1,
"Column": 3
},
Expand Down
4 changes: 2 additions & 2 deletions ...sts/Parser/__snapshots__/GraphQLParserSyntaxTests.Parse_SelectionSetNode_From_String.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"Kind": "Name",
"Location": {
"Start": 6,
"End": 8,
"End": 7,
"Line": 1,
"Column": 7
},
Expand Down Expand Up @@ -53,7 +53,7 @@
"Kind": "Name",
"Location": {
"Start": 2,
"End": 6,
"End": 5,
"Line": 1,
"Column": 3
},
Expand Down
Loading
Loading