[Nitro CLI] Fix client download command / Forward exit code#9280
Merged
tobias-tengler merged 3 commits intomainfrom Mar 1, 2026
Merged
[Nitro CLI] Fix client download command / Forward exit code#9280tobias-tengler merged 3 commits intomainfrom
tobias-tengler merged 3 commits intomainfrom
Conversation
tobias-tengler
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Nitro CLI runtime behavior to better align with JSON payload naming and to correctly propagate command exit codes from the System.CommandLine pipeline.
Changes:
- Configure
NitroCLIJsonContextsource generation to use camelCase JSON property naming. - Update
Program.Mainto return theInvokeAsyncexit code (Task<int>) rather than discarding it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Nitro/CommandLine/src/CommandLine/Services/Configuration/NitroCLIJsonContext.cs |
Sets camelCase naming policy for source-generated JSON serialization/deserialization used by CLI config + client download parsing. |
src/Nitro/CommandLine/src/CommandLine/Program.cs |
Returns the System.CommandLine invocation exit code to the host process. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.