Add ErrorModes to HotChocolate#9470
Merged
michaelstaib merged 4 commits intomainfrom Mar 28, 2026
Merged
Conversation
michaelstaib
commented
Mar 28, 2026
| var requestBuilder = OperationRequestBuilder.New() | ||
| .SetDocument(endpointDescriptor.Document) | ||
| .SetErrorHandlingMode(ErrorHandlingMode.Halt) | ||
| .SetErrorHandlingMode(ErrorHandlingMode.Propagate) |
Member
Author
There was a problem hiding this comment.
@tobias-tengler I have removed the halt mode as there are serious issues with it in combination with incremental delivery.
This has a downstream effect to this as we now get the old behavior as default.
I am not yet sure what we should use, we could also use the new error mode here.
Member
There was a problem hiding this comment.
Mhmm. The intention was that there is no unnecessary work done if there's a single error the entire request will be returned as empty with HTTP 500 in that case anyway...
| } | ||
|
|
||
| [Fact] | ||
| public async Task Execution_Is_Halted_While_Subscription_Is_Still_Ongoing() |
| } | ||
|
|
||
| [Fact] | ||
| public async Task Execution_Is_Halted_While_Http_Request_In_Node_Is_Still_Ongoing() |
| var requestBuilder = OperationRequestBuilder.New() | ||
| .SetDocument(endpointDescriptor.Document) | ||
| .SetErrorHandlingMode(ErrorHandlingMode.Halt) | ||
| .SetErrorHandlingMode(ErrorHandlingMode.Propagate) |
Member
There was a problem hiding this comment.
Mhmm. The intention was that there is no unnecessary work done if there's a single error the entire request will be returned as empty with HTTP 500 in that case anyway...
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.