[Nitro CLI] Improve wording of error messages#9577
Merged
tobias-tengler merged 3 commits intomainfrom Apr 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Nitro CLI failure/validation messaging to be more direct and consistent across schema, OpenAPI, MCP, client, and Fusion commands, and adjusts snapshots accordingly.
Changes:
- Reworded multiple validation/publish failure messages (e.g., “failed …” → “did not pass” / “was rejected”).
- Extended
INitroConsoleActivityfailure APIs to optionally override the displayed failure message when failing with details. - Updated command implementations and inline snapshot tests to match the new wording.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Schemas/ValidateSchemaCommandTests.cs | Updates snapshots for new schema validation failure wording. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Schemas/PublishSchemaCommandTests.cs | Updates snapshots for schema publish rejection and validation wording changes. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/OpenApi/ValidateOpenApiCollectionCommandTests.cs | Updates snapshots for OpenAPI validation failure wording. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/OpenApi/PublishOpenApiCollectionCommandTests.cs | Updates snapshots for OpenAPI publish rejection and validation wording changes. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Mcp/ValidateMcpFeatureCollectionCommandTests.cs | Updates snapshots for MCP validation failure wording. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Mcp/PublishMcpFeatureCollectionCommandTests.cs | Updates snapshots for MCP publish rejection and validation wording changes. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionValidateCommandTests.cs | Updates snapshots for Fusion validate flows (composition + validation wording). |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionPublishCommandTests.cs | Updates snapshots for Fusion publish rejection/validation/composition wording changes. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionConfigurationPublishValidateCommandTests.cs | Updates snapshots for Fusion publish-validate command error wording. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionConfigurationPublishCommitCommandTests.cs | Updates snapshots for Fusion publish-commit failure wording. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Clients/ValidateClientCommandTests.cs | Updates snapshots for client validation failure wording. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Clients/PublishClientCommandTests.cs | Updates snapshots for client publish rejection and validation wording changes. |
| src/Nitro/CommandLine/src/CommandLine/Services/Console/NitroConsoleActivity.cs | Adds optional failure-message override to Fail(details)/FailAllAsync(...). |
| src/Nitro/CommandLine/src/CommandLine/Services/Console/INitroConsoleActivity.cs | Updates interface signatures to allow optional failure-message overrides. |
| src/Nitro/CommandLine/src/CommandLine/Messages.cs | Changes the shared “validation failed” string to “Validation did not pass.” |
| src/Nitro/CommandLine/src/CommandLine/Commands/Schemas/ValidateSchemaCommand.cs | Updates thrown error message when schema validation fails. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Schemas/SchemaHelpers.cs | Uses the new FailAllAsync(details, message) to control displayed failure text. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Schemas/PublishSchemaCommand.cs | Updates failure handling to “rejected” wording for schema publish failures. |
| src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/ValidateOpenApiCollectionCommand.cs | Updates failure handling to new OpenAPI validation wording. |
| src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/PublishOpenApiCollectionCommand.cs | Updates failure handling to “rejected” wording for OpenAPI publish failures. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/ValidateMcpFeatureCollectionCommand.cs | Updates failure handling to new MCP validation wording. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/PublishMcpFeatureCollectionCommand.cs | Updates failure handling to “rejected” wording for MCP publish failures. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/PublishCommand/FusionConfigurationPublishValidateCommand.cs | Updates thrown error message for Fusion publish-validate failures. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionValidateCommand.cs | Updates wording for Fusion validation failures and composition failures. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishHelpers.cs | Updates Fusion publish failure handling to “rejected” wording; uses message override APIs. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishCommand.cs | Updates error output wording for validation failure in Fusion publish flow. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Clients/ValidateClientCommand.cs | Updates failure handling to new client validation wording. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Clients/PublishClientCommand.cs | Updates failure handling to “rejected” wording for client publish failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.