Skip to content

[Nitro CLI] Improve fusion download error message#9618

Merged
tobias-tengler merged 1 commit intomainfrom
fix/fusion-download-error-message
Apr 29, 2026
Merged

[Nitro CLI] Improve fusion download error message#9618
tobias-tengler merged 1 commit intomainfrom
fix/fusion-download-error-message

Conversation

@tobias-tengler
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 29, 2026 12:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves Nitro CLI’s fusion download failure messaging when no Fusion archive is available, aligning the updated command behavior with the test suite.

Changes:

  • Updates the fusion download “missing configuration” error message to mention the requested gateway format version.
  • Updates the corresponding test snapshot expectation.
  • Adjusts the archive version string passed to DownloadLatestFusionArchiveAsync.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionDownloadCommand.cs Updates the null-stream ExitException message and changes the requested archiveVersion passed to the client.
src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionDownloadCommandTests.cs Updates snapshot expectation for the improved error message.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tobias-tengler tobias-tengler merged commit 832cda9 into main Apr 29, 2026
143 checks passed
@tobias-tengler tobias-tengler deleted the fix/fusion-download-error-message branch April 29, 2026 13:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6a3b7a3) to head (1f0a0e4).
⚠️ Report is 1166 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #9618       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants