Tweak default security#9630
Merged
tobias-tengler merged 2 commits intomainfrom May 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts HotChocolate’s default security behavior to be consistent across environments and adds a per-request escape hatch for returning Fusion operation plans even when globally disallowed.
Changes:
- Always enable
AddMaxAllowedFieldCycleDepthRule()under default security (no longer environment-gated). - Add per-request override support to allow returning a Fusion operation plan when
Fusion-Operation-Plan: 1is sent, even ifFusionRequestOptions.AllowOperationPlanRequestsis false. - Add/adjust test coverage and snapshots for the new default-security and operation-plan behaviors.
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Fusion/src/Fusion.AspNetCore/DependencyInjection/FusionServerServiceCollectionExtensions.cs | Enables field-cycle-depth validation rule unconditionally when default security is on. |
| src/HotChocolate/AspNetCore/src/AspNetCore/Extensions/HotChocolateAspNetCoreServiceCollectionExtensions.cs | Enables field-cycle-depth validation rule unconditionally when default security is on. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Extensions/FusionRequestContextExtensions.cs | Adds per-request override check to allow operation plan requests. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/OperationPlanRequestOverrides.cs | Introduces internal feature record to represent per-request operation plan allowance. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Extensions/OperationPlanRequestOverridesExtensions.cs | Adds OperationRequestBuilder.AllowOperationPlanRequest() extension to set the per-request override. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/FusionTestBase.cs | Extends test helper to pass through disableDefaultSecurity into gateway server setup. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/DefaultSecurityTests.cs | Updates/expands Fusion default security tests, including operation-plan allow/deny and per-request override behavior. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/snapshots/*.snap | Adds snapshots for the new Fusion operation-plan request scenarios. |
| src/HotChocolate/AspNetCore/test/AspNetCore.Tests/DefaultSecurityTests.cs | Adds AspNetCore default security tests covering introspection and field-cycle-depth enforcement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FieldCycleDepthRuleregardless of environment to avoid surprises when switching environments