Skip to content

Fix EXPLAIN (VERBOSE) for window functions#223

Merged
theory merged 1 commit intomainfrom
fix-verbose-window
Apr 28, 2026
Merged

Fix EXPLAIN (VERBOSE) for window functions#223
theory merged 1 commit intomainfrom
fix-verbose-window

Conversation

@serprex
Copy link
Copy Markdown
Member

@serprex serprex commented Apr 19, 2026

No description provided.

@serprex serprex requested a review from theory April 19, 2026 16:00
Copy link
Copy Markdown
Collaborator

@theory theory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you. Am I wrong in thinking that it's kind of a hack, though? I wonder if the core needs more tooling around this sort of thing.

Comment thread src/fdw.c Outdated
Comment thread test/sql/window_functions.sql
@serprex serprex force-pushed the fix-verbose-window branch from ea27d22 to eb64c62 Compare April 19, 2026 16:12
@serprex
Copy link
Copy Markdown
Member Author

serprex commented Apr 19, 2026

yes, this is absolutely a hack, unfortunately postgres deparsing lends itself to being hacked around for FDWs

@serprex serprex force-pushed the fix-verbose-window branch 3 times, most recently from 1d5bf41 to 66516a6 Compare April 19, 2026 16:27
@theory theory force-pushed the fix-verbose-window branch from 66516a6 to 7466eb2 Compare April 28, 2026 06:11
@theory theory merged commit 7466eb2 into main Apr 28, 2026
36 checks passed
@theory theory deleted the fix-verbose-window branch April 28, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants