feat: add three-state secure option (on/off/auto) for TLS control#227
Open
x4m wants to merge 1 commit intoClickHouse:mainfrom
Open
feat: add three-state secure option (on/off/auto) for TLS control#227x4m wants to merge 1 commit intoClickHouse:mainfrom
x4m wants to merge 1 commit intoClickHouse:mainfrom
Conversation
theory
reviewed
May 1, 2026
Comment on lines
+40
to
+42
| - name: Show regression diffs (DSO) | ||
| if: failure() | ||
| run: cat regression.diffs || true |
Collaborator
There was a problem hiding this comment.
This is not necessary; pg-build-test does it.
theory
approved these changes
May 1, 2026
Collaborator
theory
left a comment
theory
left a comment
There was a problem hiding this comment.
Very useful, thank you @x4m. I think we can drop the ch_ prefix where the other properties or parameters don't use it, and I'm not sure the test uploading stuff is necessary (and the cat calls are not), but otherwise it looks great!
Comment on lines
+56
to
+58
| - name: Show regression diffs (Static) | ||
| if: failure() | ||
| run: cat regression.diffs || true |
| char *username; | ||
| char *password; | ||
| char *dbname; | ||
| ch_tls_mode tls; /* TLS mode; CH_TLS_AUTO when not specified */ |
Collaborator
There was a problem hiding this comment.
No need for the ch_ prefix here; the struct already has it.
| chfdw_extract_options(List * defelems, char **driver, char **host, int *port, | ||
| char **dbname, char **username, char **password); | ||
| char **dbname, char **username, char **password, | ||
| ch_tls_mode * tls); |
Collaborator
There was a problem hiding this comment.
Suggested change
| ch_tls_mode * tls); | |
| tls_mode * tls); |
| chfdw_extract_options(List * defelems, char **driver, char **host, int *port, | ||
| char **dbname, char **username, char **password) | ||
| char **dbname, char **username, char **password, | ||
| ch_tls_mode * tls) |
Collaborator
There was a problem hiding this comment.
Suggested change
| ch_tls_mode * tls) | |
| tls_mode * tls) |
Comment on lines
+43
to
+50
| - name: Upload actual results (DSO) | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: regression-results-pg${{ matrix.pg }}-${{ matrix.os.arch }}-dso | ||
| path: | | ||
| regression.diffs | ||
| results/ |
Collaborator
There was a problem hiding this comment.
I always look at the logs for result output. What does this achieve?
theory
requested changes
May 1, 2026
serprex
reviewed
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Today TLS is chosen over non-obvious heuristics. Maybe let's give a user explicit control over it?
(I'll drop changes to .github/workflows/* after discussion, I needed them for debug)