Add WebSocket support to JSON-RPC#725
Merged
kseo merged 1 commit intoCodeChain-io:masterfrom Sep 21, 2018
Merged
Conversation
kakao-jun-e
force-pushed
the
jsonrpc_ws
branch
4 times, most recently
from
7190622 to
2ef5e2a
Compare
Member
|
@redongjun Would you resolve the conflicts first? |
kseo
requested changes
Sep 19, 2018
| help: Address of desired password change | ||
| required: true | ||
| index: 1 | ||
|
|
codechain/rpc.rs
Outdated
| }, | ||
| Err(e) => Err(format!("WebSockets error: {:?}", e)), | ||
| Ok(server) => { | ||
| info!("WebSockets Listening on {}", addr); |
Member
There was a problem hiding this comment.
Use cinfo! macro. There is RPC log target.
kakao-jun-e
force-pushed
the
jsonrpc_ws
branch
from
2ef5e2a to
466a133
Compare
kakao-jun-e
force-pushed
the
jsonrpc_ws
branch
from
466a133 to
8bf6ef8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #225
I have tested it as follows :