Add sum calculation functionality to dev CLI setup subcommand#953
Open
r6915ee wants to merge 1 commit intoCodenameCrew:mainfrom
Open
Add sum calculation functionality to dev CLI setup subcommand#953r6915ee wants to merge 1 commit intoCodenameCrew:mainfrom
r6915ee wants to merge 1 commit intoCodenameCrew:mainfrom
Conversation
The subcommand uses this feature to compare the sha256 sums of the previous and current building/libs.xml files in order to decide whether or not to initiate the setup process. It adds an `--ignore-sum` flag to immediately pass the check used for this. This also clears up the help message for the subcommand in question, updates both `setup-` scripts to allow for variable arguments, and adds `--all` as an alias for `--reinstall`.
Member
|
.sum? |
Contributor
Author
Those files simply contain the last sha256 hash that was created from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev CLI's setup subcommand has a new feature that allows it to calculate the sha256 hash of the current libraries file, storing it into an ignored
.sumfile. Without the new--ignore-sumflag, if the hash of the current file and the hash presented in the sum file are the same, then the setup process won't continue. The primary use case of this that I see is to avoid having to reinstall the libraries in the case of #952, where the script would always be run every time the development shell was entered.From the commit message: