Skip to content

Fix sampling issue with fp16 intermediates.#13099

Merged
comfyanonymous merged 2 commits intomasterfrom
comfyanonymous-patch-1
Mar 21, 2026
Merged

Fix sampling issue with fp16 intermediates.#13099
comfyanonymous merged 2 commits intomasterfrom
comfyanonymous-patch-1

Conversation

@comfyanonymous
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c2bfaf1e-2501-4108-aa3f-635cd2728eb2

📥 Commits

Reviewing files that changed from the base of the PR and between 7169a21 and b5ec6ed.

📒 Files selected for processing (1)
  • comfy/samplers.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • comfy/samplers.py

📝 Walkthrough

Walkthrough

This PR makes explicit dtype conversions in comfy/samplers.py: CFGGuider.outer_sample now casts noise and latent_image to torch.float32 when moving them to device, and CFGGuider.sample converts the derived/unpacked denoise_mask to floating point via .float(). Control flow and public signatures remain unchanged; no other behavioral changes were introduced.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the issue being fixed and why the dtype conversions resolve it.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: explicit dtype conversions to fp32 and float to fix sampling issues with fp16 intermediates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@comfyanonymous comfyanonymous merged commit b5d32e6 into master Mar 21, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the comfyanonymous-patch-1 branch March 21, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant