Allow flux conditioning without a pooled output.

[comfyanonymous]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aae646ea-2721-4a7f-82f8-0f4536b975b2

📥 Commits

Reviewing files that changed from the base of the PR and between 6a2cdb8 and 6dc5900.

📒 Files selected for processing (1)

• comfy/model_base.py

---

📝 Walkthrough

Walkthrough

The encode_adm method in two model classes (SD3 and Flux) in comfy/model_base.py has been modified to safely retrieve the pooled_output value from kwargs. Instead of using direct dictionary indexing, which would raise a KeyError if the key is absent, the code now uses the .get() method with None as the default return value when pooled_output is not present in kwargs.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess whether it relates to the changeset.	Add a description explaining the purpose of allowing Flux conditioning without pooled output and any relevant context or use cases.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: allowing Flux conditioning to work without requiring a pooled output by using a safe lookup instead of direct indexing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}