Publish NuGet artifacts only from Windows build#247
Merged
TheCodeTraveler merged 1 commit intomainfrom Oct 2, 2023
Merged
Conversation
TheCodeTraveler
approved these changes
Oct 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
While preparing a new release I found out that we are publishing NuGets from both the macOS and the Windows build. But only the Windows build has all the target platforms we need and are the libraries that are signed with a certificate.
The reason we didn't discover this earlier is basically because we got lucky until now. The macOS build is faster than the Windows one. So the macOS build would finish in let's say 10 minutes and produce NuGets, but then Windows would finish a couple of minutes later and override those NuGets and those would be used by a potential release.
This worked fine, until now the macOS build failed and I had to retry it. Once retries, it succeeded, but this time overriding the NuGets (again!) from Windows to the macOS ones. And because of that they were blocked for release because these NuGets aren't signed.
To overcome all this, let's just only produce NuGets from Windows.