Skip to content

Add String-based Gesture Extensions#339

Merged
TheCodeTraveler merged 2 commits intomainfrom
Add-String-Based-Bindings-for-GestureExtensions
Nov 25, 2024
Merged

Add String-based Gesture Extensions#339
TheCodeTraveler merged 2 commits intomainfrom
Add-String-Based-Bindings-for-GestureExtensions

Conversation

@TheCodeTraveler
Copy link
Copy Markdown
Collaborator

@TheCodeTraveler TheCodeTraveler commented Nov 25, 2024

Description of Change

This PR adds string-based Gesture Extensions that were mistakenly removed in v5.0.0.

String-based bindings are still valid in .NET MAUI 9.0.0, however they are not trim-safe.

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

Additional information

Added [RequiresUnreferencedCode("Using bindings with string paths is not trim safe. Use expression-based binding instead.")] because string-based bingings are not trim-safe.

Moved Typed Bindings Gesture Extensions to GesturesExtensions.TypedBindings.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants