Skip to content

Support Nullable Bindable Properties in TypedBinding.cs #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoeVoo wants to merge 3 commits into from
Closed

Support Nullable Bindable Properties in TypedBinding.cs #371

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d01a987
Update TypedBinding.cs
JoeVoo Feb 19, 2025
1a0612b
Merge branch 'main' into patch-1
TheCodeTraveler Feb 21, 2025
d9ccbfa
Update TypedBinding.cs
JoeVoo Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/CommunityToolkit.Maui.Markup/TypedBinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,13 @@ void ApplyCore(TSource? sourceObject, BindableObject target, BindableProperty pr
var needsSetter = (mode == BindingMode.TwoWay && fromTarget) || mode == BindingMode.OneWayToSource;
if (needsSetter && sourceObject is not null)
{
var value = GetTargetValue(target.GetValue(property), typeof(TProperty)) ?? throw new InvalidOperationException("Unable to find target value");

var value = GetTargetValue(target.GetValue(property), typeof(TProperty));
Copy link
Copy Markdown
Contributor

@bijington bijington Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should check whether TProperty is nullable in this scenario. Thoughts @TheCodeTraveler?

if (value == null)
{
setter?.Invoke(sourceObject,default!);
return;
}

if (!BindingExpressionHelper.TryConvert(ref value, property, typeof(TProperty), false))
{
BindingDiagnostics.SendBindingFailure(this, sourceObject, target, property, "Binding", BindingExpression.CannotConvertTypeErrorMessage, value, typeof(TProperty));
Expand Down Expand Up @@ -435,4 +440,4 @@ void Unsubscribe()
handle.Listener?.Unsubscribe();
}
}
}
}