Fix the expected name of the from_file argument in txt2img#334
Open
freespirit wants to merge 1 commit intoCompVis:mainfrom
Open
Fix the expected name of the from_file argument in txt2img#334freespirit wants to merge 1 commit intoCompVis:mainfrom
freespirit wants to merge 1 commit intoCompVis:mainfrom
Conversation
The argument parser expects an argument with the name from-file but the code looks for from_file. This issue doesn't break the code but may be confusing for users of the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument parser expects an argument with the name
from-filebut the code looks forfrom_file. This issue doesn't crash the code but may be confusing for users of the script - it would cause strange behaviour.In more details:
And later in the code:
Note that the ArgumentParser looks flexible enough to accept unknown arguments but if someone reads the code and tries to enter
from-filethey may have troubles down the road whenopt.from_fileis not found and prompts won't be loaded from a file.