Skip to content

Honor standby filtering only on request #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
c-kr wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Honor standby filtering only on request #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions checkvsphere/vcmd/clusterhealth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def host_in_standby(h):
r = h['runtime'].standbyMode == "none"
if not r:
logging.debug(f"{h['name']} in standby, not considered part of cluster")
return not r

def run():
global args
Expand Down Expand Up @@ -114,8 +115,9 @@ def run():
check.exit(Status.CRITICAL, "Cluster is empty")

hosts = resolve_hosts(si, hosts)
# Hosts in standby are not considered part of the cluster
hosts = list(filter(lambda h: not host_in_standby(h), hosts))
if args.nostandby:
# Hosts in standby are not considered part of the cluster
hosts = list(filter(lambda h: not host_in_standby(h), hosts))

cluster_size = len(hosts)
failed_members = sum(1 for h in hosts if host_is_failed(args, h))
Expand Down