Fix Convex push crash and route warnings

[Connorbelez]

Summary

• Remove vitest import from convex/ledger/__tests__/testUtils.ts that crashed the Convex bundler during convex dev push (vitest requires an active test runner at import time)
• Prefix route component files with - to suppress TanStack Router warnings about non-route files in src/routes/
• Minor cleanup in seed files and reconciliation

Test plan

• Run bunx convex dev — should push successfully without the vitest analysis error
• Verify /demo/governed-transitions pages load without route warnings
• Run bun run test to confirm ledger tests still pass

🤖 Generated with Claude Code

Summary by CodeRabbit

• Style

  • Reformatted code expressions for improved readability across multiple files.

• Chores

  • Refactored component import paths and updated internal type checking patterns.

[greptile-apps]

Connorbelez has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[sourcery-ai]

Sorry @Connorbelez, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[coderabbitai]

Warning

Rate limit exceeded

@Connorbelez has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0bd73918-c9ea-4d4b-8e36-29511e43c56f

📥 Commits

Reviewing files that changed from the base of the PR and between cdd7ca4 and 8b15d98.

📒 Files selected for processing (4)

• src/routes/demo/governed-transitions/-components/GovernedTransitionsJournalView.tsx
• src/routes/demo/governed-transitions/-components/GovernedTransitionsMachineView.tsx
• src/routes/demo/governed-transitions/journal.tsx
• src/routes/demo/governed-transitions/machine.tsx

📝 Walkthrough

Walkthrough

The PR consolidates formatting changes across multiple files: reformatting multi-line expressions to single lines in reconciliation, seed, and obligation state files. It replaces a test assertion with a runtime type check in testUtils and updates two component import paths to reference dash-prefixed filenames.

Changes

Cohort / File(s)	Summary
Reconciliation & Seed Formatting convex/engine/reconciliation.ts, convex/seed/seedObligation.ts, convex/seed/seedObligationStates.ts	Single-line reformatting of multi-line expressions (collectionAttempt branch, gracePeriodEnd calculation, withIndex call) with no functional changes to behavior or return values.
Test Assertion Refactor convex/ledger/__tests__/testUtils.ts	Replaced Vitest's expect runtime assertion with a direct instanceof type check in getConvexErrorCode; behavior for valid ConvexError inputs remains unchanged, error-throwing path preserved.
Governed Transitions Import Paths src/routes/demo/governed-transitions/journal.tsx, src/routes/demo/governed-transitions/machine.tsx	Updated component import paths to reference filenames with dash prefix (-GovernedTransitionsJournalView and -GovernedTransitionsMachineView).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• ENG-13 #59: Modifies convex/engine/reconciliation.ts to add reconcile/reconcileLayer2 logic alongside this PR's formatting changes.
• feat: implement commitReservation/voidReservation mutations and reservation+concurrency test suites (ENG-33, ENG-36) #105: Modifies convex/ledger/__tests__/testUtils.ts getConvexErrorCode implementation, directly intersecting with this PR's assertion refactor.
• Auth Audit - fixes  #81: Modifies convex/seed/seedObligation.ts for default error messages, overlapping with this PR's gracePeriodEnd formatting changes.

Poem

🐰 With whiskers twitched and paws a-dance,
Lines compress in formatting's trance!
Dashes bold in paths now shine,
Type-checks raw where tests align—
Cleaner code in every line! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix Convex push crash and route warnings' directly matches the main objectives: fixing a Convex push crash caused by vitest import and fixing route warnings via file prefixing.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 03-18-bug_squash

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors the demo “governed transitions” UI by extracting the machine diagram and journal table into dedicated components, while also applying a few small formatting/cleanup tweaks in Convex seed/engine code and ledger test utilities.

Changes:

• Extracted governed-transitions machine visualization and journal rendering into new _components React components.
• Updated the governed-transitions route pages to import and use the extracted components.
• Minor formatting cleanups in seed/engine code and simplified ledger test utils by removing a Vitest-only assertion/import.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/routes/demo/governed-transitions/machine.tsx	Updates route to import the extracted machine view component.
src/routes/demo/governed-transitions/journal.tsx	Updates route to import the extracted journal view component.
src/routes/demo/governed-transitions/_components/-GovernedTransitionsMachineView.tsx	New component that renders the governed transition state diagram using N8nWorkflowBlock.
src/routes/demo/governed-transitions/_components/-GovernedTransitionsJournalView.tsx	New component that renders transition journal entries via InteractiveLogsTable.
convex/seed/seedObligationStates.ts	Formatting-only change to index query chaining.
convex/seed/seedObligation.ts	Formatting-only change to date helper calls.
convex/ledger/tests/testUtils.ts	Removes Vitest expect dependency inside shared test utility function.
convex/engine/reconciliation.ts	Formatting-only change to ctx.db.get call.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.