Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Connorbelez, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe pull request expands transfer effect handler test coverage from lightweight unit tests to full integration tests using a Convex runtime harness, validating observable side effects on database documents and journal entries. Supporting documentation is added outlining implementation requirements, architecture context, completion status, and task tracking for ENG-194. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Pull request overview
This PR upgrades transfer effect coverage by replacing shallow “registry presence” assertions with integration tests that exercise the real transfer effect internal mutations and verify correct cash-ledger journal posting behavior across confirmed/failed/reversed/bridged scenarios.
Changes:
- Rewrote
convex/engine/effects/__tests__/transfer.test.tsto useconvex-testharnessing and assert actual journal entries + transfer patches. - Added explicit coverage for bridged-transfer skip behavior and fail-loud / fail-closed error paths.
- Added ENG-194 spec/task tracking docs describing the testing work and verification status.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| specs/ENG-194/tasks.md | Adds ENG-194 task checklist and verification steps for the transfer effect test rewrite. |
| specs/ENG-194/chunks/manifest.md | Introduces chunk manifest for ENG-194 work breakdown/status tracking. |
| specs/ENG-194/chunks/chunk-01-transfer-effect-tests/tasks.md | Chunk-level checklist for transfer effect integration test coverage. |
| specs/ENG-194/chunks/chunk-01-transfer-effect-tests/status.md | Records completion notes + quality gate results for the chunk. |
| specs/ENG-194/chunks/chunk-01-transfer-effect-tests/context.md | Captures implementation plan context and relevant code excerpts for ENG-194. |
| convex/engine/effects/tests/transfer.test.ts | Replaces shallow tests with integration tests validating effect handler behavior and cash ledger postings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Connorbelez
added a commit
that referenced
this pull request
Mar 28, 2026
### TL;DR Replaced shallow transfer effect tests with comprehensive integration tests that verify the actual transfer effect handlers create correct journal entries and handle edge cases properly. ### What changed? Completely rewrote `convex/engine/effects/__tests__/transfer.test.ts` to use `convex-test` integration testing instead of simple registry presence checks. The new tests verify: - `recordTransferProviderRef` patches provider references onto transfers - `publishTransferConfirmed` creates `CASH_RECEIVED` entries for inbound transfers and `LENDER_PAYOUT_SENT` entries for outbound transfers - Bridged transfers (with `collectionAttemptId`) skip duplicate cash posting - `publishTransferReversed` creates `REVERSAL` entries with proper `causedBy` linkage - `publishTransferFailed` patches failure metadata correctly - Error conditions like missing direction or missing journal entries throw appropriate errors ### How to test? Run the new integration tests: ```bash bun run test convex/engine/effects/__tests__/transfer.test.ts ``` Also verify related cash ledger tests still pass: ```bash bun run test convex/payments/cashLedger/__tests__/reversalCascade.test.ts bun run test convex/payments/cashLedger/__tests__/transferReconciliation.test.ts ``` ### Why make this change? The original tests only verified that effect handlers were registered in the registry but didn't test their actual behavior. Since these effects are critical for posting cash journal entries when transfers confirm, fail, or reverse, proper integration testing was needed to ensure the handlers work correctly with the cash ledger and handle the D4 conditional logic for bridged vs non-bridged transfers. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Expanded integration test coverage for transfer operations to validate proper ledger integration when transfers are confirmed, failed, or reversed. * **Documentation** * Added implementation specification documents for transfer effect handlers, including integration requirements and verification criteria. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Replaced shallow transfer effect tests with comprehensive integration tests that verify the actual transfer effect handlers create correct journal entries and handle edge cases properly.
What changed?
Completely rewrote
convex/engine/effects/__tests__/transfer.test.tsto useconvex-testintegration testing instead of simple registry presence checks. The new tests verify:recordTransferProviderRefpatches provider references onto transferspublishTransferConfirmedcreatesCASH_RECEIVEDentries for inbound transfers andLENDER_PAYOUT_SENTentries for outbound transferscollectionAttemptId) skip duplicate cash postingpublishTransferReversedcreatesREVERSALentries with propercausedBylinkagepublishTransferFailedpatches failure metadata correctlyHow to test?
Run the new integration tests:
bun run test convex/engine/effects/__tests__/transfer.test.tsAlso verify related cash ledger tests still pass:
Why make this change?
The original tests only verified that effect handlers were registered in the registry but didn't test their actual behavior. Since these effects are critical for posting cash journal entries when transfers confirm, fail, or reverse, proper integration testing was needed to ensure the handlers work correctly with the cash ledger and handle the D4 conditional logic for bridged vs non-bridged transfers.
Summary by CodeRabbit
Tests
Documentation