Add dedicated CRM listings support and detail adapters#408
Open
Connorbelez wants to merge 2 commits intoeng-276from
Open
Add dedicated CRM listings support and detail adapters#408Connorbelez wants to merge 2 commits intoeng-276from
Connorbelez wants to merge 2 commits intoeng-276from
Conversation
Contributor
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 44 minutes and 5 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (35)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Connorbelez, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Pull request overview
Adds dedicated CRM support for marketplace listings and enriches admin list/detail UX for listings, mortgages, obligations, and borrowers by introducing entity-aware summaries, hydrated/computed fields, and dedicated detail renderers.
Changes:
- Adds native
listingstable support to CRM system adapters + bootstrapped system object configs (fields, defaults, aggregates). - Introduces entity record materialization/hydration and wires it into table/kanban/view queries, record queries, and relation display payloads.
- Adds dedicated detail panels (listings/mortgages/obligations) and upgrades admin row/card title + supporting text semantics to be entity-aware.
Reviewed changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/admin/admin-shell.test.ts | Expands admin-shell tests for entity-aware title/supporting text and adapter semantics. |
| src/lib/auth.ts | Import ordering cleanup (no behavior change). |
| src/components/admin/shell/entity-view-adapters.tsx | Adds rollout dedicated detail adapter registry for select entities. |
| src/components/admin/shell/dedicated-detail-panels.tsx | Introduces new dedicated detail panels backed by Convex queries. |
| src/components/admin/shell/admin-view-rendering.tsx | Adds entity-specific summary formatting + updates supporting-text API. |
| src/components/admin/shell/AdminEntityTableView.tsx | Passes adapter contract into supporting-text rendering. |
| src/components/admin/shell/AdminEntityKanbanView.tsx | Passes adapter contract into supporting-text rendering. |
| convex/crm/viewQueries.ts | Materializes/hydrates records before building rows + relation display values. |
| convex/crm/types.ts | Extends computed field contract with materializationMode. |
| convex/crm/systemAdapters/queryAdapter.ts | Adds native listings pagination/get-by-id support. |
| convex/crm/systemAdapters/bootstrap.ts | Adds listings system object config + expands bootstrap to “repair” existing configs and seed defaults. |
| convex/crm/relationCellPayloads.ts | Materializes referenced records to improve relation labels. |
| convex/crm/recordQueries.ts | Materializes/hydrates query results and record detail surfaces. |
| convex/crm/entityViewHydration.ts | New hydration layer to populate entity-specific summaries before computed fields apply. |
| convex/crm/entityViewFields.ts | Adds new computed field evaluators and skips hydrated computed fields in sync evaluation. |
| convex/crm/entityAdapterRegistry.ts | Expands dedicated adapter definitions (computed fields, overrides, layout/title candidates). |
| convex/crm/detailContextQueries.ts | Adds admin-facing detail context queries for dedicated detail panels. |
| convex/crm/tests/viewEngine.test.ts | Updates adapter schema expectations for new computed/visible fields. |
| convex/crm/tests/systemAdapters.test.ts | Adds coverage for querying listings via CRM query path. |
| convex/_generated/api.d.ts | Updates generated API typings for new Convex module(s). |
| specs/ENG-280/** | Adds planning/checklist docs for the ENG-280 rollout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 17, 2026
Open
Open
Owner
Author
|
@coderabbitai please review |
Contributor
|
🧠 Learnings used✅ Actions performedReview triggered.
|
Open
This was referenced Apr 20, 2026
Open
Open
Open
Owner
Author
|
@coderabbitai please re-review |
Contributor
|
🧠 Learnings used✅ Actions performedFull review triggered. |
This was referenced Apr 20, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.