chore: remove logic that uses import importlib_metadata#13809
chore: remove logic that uses import importlib_metadata#13809brettlangdon merged 23 commits intomainfrom
Conversation
|
|
chojomok
force-pushed
the
mohammad/update_importlib_metadata
branch
from
cfbf3ed to
e837e82
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 284 ± 5 ms. The average import time from base is: 318 ± 10 ms. The import time difference between this PR and base is: -33.8 ± 0.3 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-07-08 21:18:55 Comparing candidate commit 1031720 in PR branch Found 46 performance improvements and 3 performance regressions! Performance is the same for 436 metrics, 3 unstable metrics. scenario:djangosimple-appsec
scenario:djangosimple-exception-replay-enabled
scenario:djangosimple-iast
scenario:djangosimple-span-code-origin
scenario:djangosimple-tracer
scenario:djangosimple-tracer-and-profiler
scenario:djangosimple-tracer-no-caches
scenario:djangosimple-tracer-no-databases
scenario:djangosimple-tracer-no-middleware
scenario:djangosimple-tracer-no-templates
scenario:errortrackingdjangosimple-errortracking-enabled-all
scenario:errortrackingdjangosimple-errortracking-enabled-user
scenario:errortrackingdjangosimple-tracer-enabled
scenario:errortrackingflasksqli-errortracking-enabled-all
scenario:errortrackingflasksqli-errortracking-enabled-user
scenario:errortrackingflasksqli-tracer-enabled
scenario:flasksimple-appsec-get
scenario:flasksimple-appsec-post
scenario:flasksimple-appsec-telemetry
scenario:flasksimple-tracer
scenario:flasksqli-appsec-enabled
scenario:flasksqli-iast-enabled
scenario:flasksqli-tracer-enabled
scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectsospath-ospathjoin_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
|
Performance SLOsCandidate: mohammad/update_importlib_metadata (25c4289) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
chojomok
changed the title
chojomok
added
the
changelog/no-changelog
mabdinur
left a comment
mabdinur
left a comment
There was a problem hiding this comment.
We can remove "importlib_metadata<=6.5.0; python_version<'3.8'", from pyproject.toml. This will remove this dependnacy from the ddtrace package. We should also add a release note.
mabdinur
left a comment
mabdinur
left a comment
There was a problem hiding this comment.
Left some nits. Overall LGTM!
…8ae307acfe.yaml Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
brettlangdon
left a comment
brettlangdon
left a comment
There was a problem hiding this comment.
can we get a PR description?
emmettbutler
left a comment
emmettbutler
left a comment
There was a problem hiding this comment.
Seconded @brettlangdon's comments
|
@brettlangdon + @emmettbutler - I removed the release note and added it as PR description instead. Let me know if this isn't sufficient. |
Remove importlib_metadata dependency since it is no longer needed. Support for Python 3.7 has been dropped, and dd-trace-py now requires Python 3.8 or later, which includes importlib.metadata in the standard library. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
7 participants
Remove importlib_metadata dependency since it is no longer needed. Support for Python 3.7 has been dropped, and dd-trace-py now requires Python 3.8 or later, which includes importlib.metadata in the standard library.
Checklist
Reviewer Checklist