chore(ci_visibility): test-level skipping support for itr#14115
chore(ci_visibility): test-level skipping support for itr#14115
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 278 ± 3 ms. The average import time from base is: 280 ± 2 ms. The import time difference between this PR and base is: -1.8 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: gnufede/fix-itr-test-level-skipping (63693b3) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
CI Visibility: Fix for a bug introduced in #14115 where session tags would not have the proper count of tests skipped by ITR, counting the suite number instead when ITR is configured at suite level skipping. Regression tests added for both suite level skipping and test level skipping. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
CI Visibility: Fix for a bug introduced in #14115 where session tags would not have the proper count of tests skipped by ITR, counting the suite number instead when ITR is configured at suite level skipping. Regression tests added for both suite level skipping and test level skipping. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
CI Visibility: this change is part of an effort to support both suite skipping and test skipping from ITR.
While the default value for _DD_CIVISIBILITY_ITR_SUITE_MODE was False, this mode was actually forced at the beginning of
_pytest_load_initial_conftests_pre_yield(). This PR changes the default value to True, and checks for the actual mode in a couple places in order to honor the setting when ITR is enabled.However, there is still a missing piece in order to use the test skipping mode in ITR, and it is related to the coverage payload it requires, as it is not yet properly attached in this mode, hence the commented asserts in the tests.
Checklist
Reviewer Checklist