Skip to content

Don't instantiate config client inside oav params#2004

Open
jacob720 wants to merge 1 commit intomainfrom
improve_config_client_in_oav_params
Open

Don't instantiate config client inside oav params#2004
jacob720 wants to merge 1 commit intomainfrom
improve_config_client_in_oav_params

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

@jacob720 jacob720 commented Apr 9, 2026

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner April 9, 2026 13:24
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (fe5c9c0) to head (8d903da).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2004      +/-   ##
==========================================
- Coverage   99.08%   99.08%   -0.01%     
==========================================
  Files         319      319              
  Lines       12408    12406       -2     
==========================================
- Hits        12295    12293       -2     
  Misses        113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant