Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
=======================================
Coverage 99.08% 99.08%
=======================================
Files 319 320 +1
Lines 12408 12417 +9
=======================================
+ Hits 12295 12304 +9
Misses 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Relm-Arrowny
left a comment
Relm-Arrowny
left a comment
There was a problem hiding this comment.
I am not 100% sure about the i21 fastshutter should behave like a standard shutter the other change looks good to me.
| from dodal.devices.fast_shutter import EnumTypesT, FastShutter | ||
|
|
||
|
|
||
| class FastShutterWithLateralMotor(FastShutter[EnumTypesT], Generic[EnumTypesT]): |
Contributor
There was a problem hiding this comment.
We need to ask @fajinyuan how this fast shutter actually should behave, looking at it as an outsider, it look to me this is a externally triggered fast shutter. Couple of things concern me:
- The ERIO output is the status we trying to change as if it is a standard shutter, I am not 100% sure open will mean open or it just set the default state to open and a trigger signal will close it.
- There are 4 more outputs and a source signals on that fast shutter controller we likely want to be able to access them depending of the experimental condition.
| close_state (EnumTypesT): The enum value that corresponds with closing the | ||
| shutter. | ||
| shutter_suffix (str, optional): Shutter suffix state. Defaults to CON. | ||
| lateral_suffix (str, optional): Lateral mottor suffix. Defaults to LAT. |
Contributor
There was a problem hiding this comment.
Suggested change
| lateral_suffix (str, optional): Lateral mottor suffix. Defaults to LAT. | |
| lateral_suffix (str, optional): Lateral motor suffix. Defaults to LAT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fastshutter to i21. Extended base to add the additional motor that i21 requires. Updated existing classes to reuse the same enum
OpenClosedInstructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}