Conversation
Found 166 errors in 26 files (checked 221 source files)
This reverts commit f671120.
|
LGTM. The only thing that caught me out was the |
| print_queue: queue.Queue = queue.Queue() | ||
|
|
||
| last_shown = {} | ||
| last_shown: dict[Tuple[Any, Any], Any] = {} |
There was a problem hiding this comment.
Probably not the most useful type annotation I've ever seen :)
rjgildea
left a comment
There was a problem hiding this comment.
Mostly looks sensible, although I noticed a couple of dict type annotations that could be more useful (although I haven't delved too deeply into the code to figure out if they could be more specific), e.g.:
queue_status: dict[Any, Any] = {}
and
last_shown: dict[Tuple[Any, Any], Any] = {}
But this is likely outside of the scope of this pull request which is a net improvement 👍
|
Those annotations were required as otherwise mypy throws an error, eg. Thanks to both of you |
including a bunch of pydantic and dataclasses changes right at the bottom of the diff, so would be nice to have someone else have a look at whether these
= Nonedefault fields should be truly optional.Or if they should not be optional and shouldn't have a default.