feat: Add a semantic message and tone to most field components#667
Merged
feat: Add a semantic message and tone to most field components#667
Conversation
6 tasks
frankieyan
approved these changes
Jun 2, 2022
| type ChildrenRenderProps = { | ||
| id: string | ||
| 'aria-describedby'?: string | ||
| 'aria-errormessage'?: string |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Apparently, support for this is not great on VoiceOver (or in general) 😕
https://a11ysupport.io/tech/aria/aria-errormessage_attribute
cc @craigcarlyle what do you think we could do? Maybe we make it part of the description all the time? I tested this, and VoiceOver still announces that the field is marked as invalid. But it does not announce the error text. So having it in the description would have it read out loud.
Contributor
Contributor
Author
There was a problem hiding this comment.
Done in the last commit.
731a0a7 to
5f6c836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Short description
Test plan
Review manually the live components in the various new stories titled "Message Tone Story" in storybook
TextFieldSelectFieldPasswordFieldTextAreaDemo
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
New minor release