feat: Add support for an error status and message in most form field components#659
Closed
feat: Add support for an error status and message in most form field components#659
Conversation
gnapse
changed the title
craigcarlyle
approved these changes
May 18, 2022
| }) | ||
|
|
||
| it('is marked as invalid and with an error message if an error message is given', () => { | ||
| render(<SelectField data-testid="select-field" label="Gender" error="Must select one" />) |
Contributor
There was a problem hiding this comment.
Could we maybe change this label or error message?
Suggested change
| render(<SelectField data-testid="select-field" label="Gender" error="Must select one" />) | |
| render(<SelectField data-testid="select-field" label="Favourite ice cream flavour" error="Must select one" />) |
10 tasks
Contributor
Author
|
Superseded by #667 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a semantic error message to most form field components.
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
New minor release.