fix: Tweak badge height as per design mocks#757
Conversation
|
@gnapse I'm running into an issue in the "Publish to Chromatic" build: Based on "the internet", it seems like this is due to fact that that build is running on Node v18, even though I don't think we're actually intentionally supporting it in Reactist. Have you encountered this before? I feel like a possible solution could be to ensure that we're using node v16 in the chromatic configs 👀 Looking now. Edit: Errr actually not sure this is popping up now. I don't think we updated any dependencies recently... 🤔 Edit: It actually started failing even before this PR, when I merged my previous PR. See: https://github.com/Doist/reactist/actions/runs/4224761740/jobs/7336138735 The PR that caused that build failure was #755 It's possible that the output is confusing and this is just an issue with my storybook stories since the output also says: Edit: Running locally works fine (no errors). 🤷♀️ |
eb622b1 to
7eff956
Compare
|
Fix for the Chromatic build is in #758 |
35d1606 to
e5359cd
Compare
Short description
Minor follow-up to #755, after testing the new version in todoist-web. Looks like this:
which looks too tall.
However, what we know is that:
Therefore the padding should be 2.5px at the top and 2.5px at the bottom. I had 3px and 3px before this change. Apologies, I hadn't checked the mock carefully enough apparently.
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
Patch bump.