chore: Explicitely enforce Chromatic build node version#758
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
When working on #757, I noticed en error in the "Publish to Chromatic" build:
Based on "the internet", it seems like this is due to fact that that build is running on Node v18, even though we're not (yet) intentionally supporting it in Reactist.
It actually started failing even before this PR, when I merged my previous PR. See this build: https://github.com/Doist/reactist/actions/runs/4224761740/jobs/7336138735
The best solution here seems to be to ensure that, before running the Chromatic publish step, we actually select the intended Node version, instead of relying on the default Node version that's brought in by
ubuntu-latest, which apparently recently switched from Node 16 to Node 18.I actually "took" this fix from todoist-web (cypress build): https://github.com/Doist/todoist-web/blob/main/.github/workflows/check-cypress-automation.yml#L92-L97
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning