test: Introduce Chromatic for visual regression tests#730
Merged
Conversation
17711ce to
e4c8ec0
Compare
6 tasks
01fadfb to
d415f03
Compare
d415f03 to
78a6e40
Compare
d2ae781 to
e169144
Compare
78a6e40 to
721999e
Compare
4759170 to
507265d
Compare
531e73e to
1f8d62c
Compare
Member
|
@gnapse I'm going to re-roll as I'll be off the first half of next week. Super interesting though, I'll definitely check it out when I'm back 👍 |
This reverts commit 5deb96e.
scottlovegrove
approved these changes
Jan 24, 2023
Contributor
scottlovegrove
left a comment
There was a problem hiding this comment.
Was able to view the storybook without the chromatic account.
Was able to create a chromatic account and once in, it showed me the Reactist project. There were two there, one is Reactist the other is reactist. I think the former is the one we are really expecting, correct?
Contributor
Author
Yup. I had not noticed that, and do not know how that other one came into being, but I now removed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This is work in progress, not even sure it's going to make it tomainyet.Chromatic is a visual regression testing system provided via an external service (SaaS). It is based on Storybooks (in fact, it's provided by the creators and maintainers of Storybooks). What it does is, it runs your Storybooks stories and creates screenshots of them, which are then used as the basis for comparing when new screenshots are taken in the future.
This PR integrates Chromatic with Reactist's PR builds, so that whenever a PR is created, Chromatic is run and runs the visual regression tests. Via Chromatic's UI, you can review the changes and approve or reject any visual changes that the new PR may have created. More details about this below.
Here’s a sneak peek of what we get with Chromatic:
Snapshot changes need to be approved
Checks in the CI build that come from Chromatic. If there are snapshot differences, they need to be approved in Chromatic’s UI first
Once all changes are approved in Chromatic, the CI step is marked as passed
If the reviewer in Chromatic does not accept all visual changes, the CI step is marked as failed instead
Storybooks instance per PR
Related references
Test plan
We'll take it from there once you see the project in Chromatic. This is mostly to validate that we can all use Chromatic for collaboration.
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdVersioning
This does not need to generate a new release, as it's all inward improvements for maintainers only. No new user-facing features are included here.