fix: Explicitly omit crossOrigin and placeholder props#812
Merged
pawelgrimm merged 3 commits intomainfrom Jan 16, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
Short description
Due to an update to
@types/react, certain intrinsic HTML element type have been updated to remove unsupported props, namely:crossOriginfrom<input>and<textarea>placeholderfrom<h1>,<h2>, etc.This means that if a consumer of this package were to upgrade their
@types/react, while this package retains the older types, usages of components such as<TextInput>and<Heading>would be met with type errors complaining about missing those props that have been removed.The more correct solution here would be to update the
@types/reactpackage in THIS package, we cannot do so because it causes similar errors stemming fromariakit, which is not trivial to upgrade.As an interim solution, we are explicitly excluding those removed props from affected Reactist component props.
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refVersioning
This is technically a breaking change, as the interface of many components has changed.