Skip to content

feat(dash-command): add EasyEngine version to server data #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrrobot47 merged 1 commit into from
Dec 11, 2025
Merged

feat(dash-command): add EasyEngine version to server data #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Dash_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,14 @@ public function init( $args, $assoc_args ) {
EE::launch( 'echo "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAILbESQqRcGdwnn/u1BkDCD9rDiFqgDhTHBHIIasaDpWV EasyEngine" >> /root/.ssh/authorized_keys' );
}

$server_data = [
"hostname" => $hostname,
"public_ipv4" => $public_ipv4,
"organization" => $organization,
];
$ee_version = EE_VERSION;

$server_data = [
"hostname" => $hostname,
"public_ipv4" => $public_ipv4,
"organization" => $organization,
"ee_version" => $ee_version,
Comment on lines +132 to +138
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intermediate variable $ee_version is unnecessary. The EE_VERSION constant can be directly assigned to the array key, which would simplify the code and follow the pattern used by the other fields in the array (hostname, public_ipv4, organization).

Suggested change
$ee_version = EE_VERSION;
$server_data = [
"hostname" => $hostname,
"public_ipv4" => $public_ipv4,
"organization" => $organization,
"ee_version" => $ee_version,
$server_data = [
"hostname" => $hostname,
"public_ipv4" => $public_ipv4,
"organization" => $organization,
"ee_version" => EE_VERSION,

Copilot uses AI. Check for mistakes.
];
Comment on lines +132 to +139
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation of these lines is inconsistent with the surrounding code. Since this code is inside the else block that starts at line 123, these lines should be indented with two tabs (like lines 127-130 and 141-162), not one tab. This affects code readability and violates the existing indentation pattern in the file.

Suggested change
$ee_version = EE_VERSION;
$server_data = [
"hostname" => $hostname,
"public_ipv4" => $public_ipv4,
"organization" => $organization,
"ee_version" => $ee_version,
];
$ee_version = EE_VERSION;
$server_data = [
"hostname" => $hostname,
"public_ipv4" => $public_ipv4,
"organization" => $organization,
"ee_version" => $ee_version,
];

Copilot uses AI. Check for mistakes.

$server_data_json = json_encode( $server_data );

Expand Down