Skip to content

Implement Fix() for cc_grpc_library rule #200

@mateusz-olczyk

Description

@mateusz-olczyk

Hmmm... You might be right. I've implemented wider logic than needed. On the other hand fixing rules like that, when they already exist anyway, may be useful. I mean, e.g. setting proto_only = True when no gRPC services exist in the .proto file, etc.

So what do you think about moving some part of this logic to the Fix() method? This way, we still encourage the use of the better style, but if somebody already has "deprecated" rules, we can at least help with checking that everything is correct.

Originally posted by @mateusz-olczyk in #194 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions