refactor(ci): Consolidate CI and TDD workflows into single pipeline#690
Merged
TGTGamer merged 6 commits intocursor/effect-vitest-tests-bootstrap-6d00from Mar 16, 2026
Conversation
- Add composite actions: ci-setup (checkout, pnpm, node, install) and checkout-tests-branch - Merge ci.yml and tests-repo-pr-tdd.yml into one workflow - Main checks (lint, build, typecheck) run on push and PR - TDD flow (create-tests, run-tdd-tests, review) runs only on PR - Remove redundant tests-repo-pr-tdd.yml - Update tdd-and-test-creation.md to reference consolidated workflow Co-authored-by: Jonathan S <jonathan@resnovas.com>
|
Merging to
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Comment |
Replace manual git -C tests checkout with: - git config submodule.tests.branch - git submodule update --remote tests Falls back to default branch when PR branch doesn't exist yet. Co-authored-by: Jonathan S <jonathan@resnovas.com>
Composite actions: - security-preamble: Harden Runner + optional Workflow Telemetry - checkout-repo: lightweight checkout with submodules (no pnpm) - git-ssh-setup: SSH key + git config for signed commits Workflow updates: - codeql, security-*, management, chore: use new composites - publish: use ci-setup (added optional registry-url) - ci-setup: add optional registry-url for publish workflows Merged workflows: - tests-repo-branch-sync + tests-repo-merge-sync → tests-repo-sync.yml (ensure-branch on push, merge-on-pr-close on PR closed) Co-authored-by: Jonathan S <jonathan@resnovas.com>
Local composite actions (.github/actions/*) require the repo to be checked out first. Add actions/checkout as the first step in all workflows that use local actions. - Add skip-checkout option to ci-setup to avoid redundant checkout - Remove unused checkout-repo composite (replaced by actions/checkout) Co-authored-by: Jonathan S <jonathan@resnovas.com>
- Cache Nx .nx/cache via actions/cache (key: pnpm-lock + nx.json) - Set NX_REJECT_UNKNOWN_LOCAL_CACHE=0 so Nx accepts cache from different runners (required when not using Nx Cloud) - pnpm store already cached via setup-node cache: 'pnpm' Speeds up lint/build/typecheck and publish by reusing Nx computation cache. Co-authored-by: Jonathan S <jonathan@resnovas.com>
Local composite actions don't support pre/post execution, causing: - 'pre execution is not supported' warning - harden-runner post-step ENOENT on post_event.json - Workflow Telemetry 403 errors (external service) Replace security-preamble composite with direct harden-runner step in each workflow. Remove Workflow Telemetry (was failing with 403). Co-authored-by: Jonathan S <jonathan@resnovas.com>
ab6bb76
into
cursor/effect-vitest-tests-bootstrap-6d00
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates CI workflows, adds reusable composite actions, and merges related workflows for a cleaner TDD flow and easier maintenance.
Changes
New composite actions
Workflow updates
ci-setup(added optionalregistry-urlfor npm publish).registry-urlinput for publish workflows.Merged workflows
ensure-branch: On push (non-main), ensure matching branch exists in Eventiva/tests.merge-on-pr-close: On PR closed (merged to main), merge tests branch into default.Benefits