[BONUS PAYMENT] After requesting money from a Workspace, clicking on the Workspace name doesn't do anything

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to dev on web chrome
2. Create a new workspace
3. Go to the new workspace chat (with square logo) on LHN
4. Click on + and click on request money
5. Enter amount and click on next. Now on request money page, hover over the workspace name and notice the pointer cursor is shown. If you try to click on it, nothing happens.
6. Follow the same steps on any individual user chat and notice if you click on the user on request money page, it opens the user details.

Expected Result:

After requesting money from a Workspace, a user should be able to click on the Workspace name to be brought to the Details tab of that Workspace - example below:

Actual Result:

Cursor pointer in workspace chat even when it's not clickable and does nothing when clicked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: dev - v1.3.35-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688732531740269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01005525eef2eeb6a9
• Upwork Job ID: 1679022727333158912
• Last Price Increase: 2023-07-12

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Cursor pointer in workspace chat even when it's not clickable and does nothing when clicked

What is the root cause of that problem?

We only open details for user profile, and do nothing for a workspace.

App/src/components/MoneyRequestConfirmationList.js

Lines 212 to 217 in 60f4817

	const navigateToUserDetail = (option) => {
	if (!option.accountID) {
	return;
	}
	Navigation.navigate(ROUTES.getProfileRoute(option.accountID));
	};

What changes do you think we should make in order to solve the problem?

Open workspace details when the clicked item is a workspace.

const navigateToUserDetail = (option) => {
    if (option.accountID) {
        Navigation.navigate(ROUTES.getProfileRoute(option.accountID));
        return;
    }
    if(option.reportID){
        Navigation.navigate(ROUTES.getReportDetailsRoute(option.reportID));
    }
};

ROUTES.getReportDetailsRoute is the route that workspace header view opened when clicked see here.

result

Screen.Recording.2023-07-12.at.6.43.25.AM.mov

What alternative solutions did you explore? (Optional)

[jliexpensify]

I can't access DEV (not an Engineer). Going to reassign this to someone in Engineering to triage.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jliexpensify]

Hi @MonilBhavsar - do you mind checking if this is a bug on DEV? Let me know if it is and I'll handle Upworks, cheers!

[MonilBhavsar]

I am able to reproduce. I am not sure why it mentions DEV, as it is happening on staging too.
Should we open Workspace settings page here? For users, we open details page, but there is no such details page for workspace.

[jliexpensify]

Should we open Workspace settings page here? For users, we open details page, but there is no such details page for workspace.

Hi @MonilBhavsar - that sounds like a new feature. I'm also not sure where we'd bring the user to - the Workspace itself doesn't have a "profile", so I'd think this isn't a bug.

I can ask internally though.

EDIT: https://expensify.slack.com/archives/C01SKUP7QR0/p1689050852321279