[HOLD for payment 2023-08-16] [$1000] Desktop - Chat - “Paste as plain text” isn't present on command in the context menu

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to staging
2. Open any chat and Copy the text with markdown
3. Paste this text without any markdown by right clicking and selecting "Paste as plain text"

Expected Result:

“Paste as plain text” should present on command in the context menu.

Actual Result:

“Paste as plain text” isn't present on command in the context menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.45-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/3549733

Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6141165_desktop.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0134ff08ce327769dc
• Upwork Job ID: 1684993452633849856
• Last Price Increase: 2023-07-28

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ygshbht]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Currently, when using the desktop chat, there is no option in the context menu to "Paste as plain text".

What is the root cause of that problem?

The existing code enables the context menu, but it lacks the feature to paste as plain text.

App/desktop/main.js

Lines 28 to 40 in 96c765d

	// Initialize the right click menu
	// See https://github.com/sindresorhus/electron-context-menu
	// Add the Paste and Match Style command to the context menu
	contextMenu({
	append: (defaultActions, parameters) => [
	new MenuItem({
	// Only enable the menu item for Editable context which supports paste
	visible: parameters.isEditable && parameters.editFlags.canPaste,
	role: 'pasteAndMatchStyle',
	accelerator: 'CmdOrCtrl+Shift+V',
	}),
	],
	});

What changes do you think we should make in order to solve the problem?

To introduce this functionality, we can modify the existing code to include a new menu item that enables the "Paste as plain text" feature. This feature will only be visible and enabled in an editable context where paste is supported.

Here is the updated code:

contextMenu({
    append: (defaultActions, parameters, browserWindow) => [
        new MenuItem({
            // Only enable the menu item for Editable context which supports paste
            visible: parameters.isEditable && parameters.editFlags.canPaste,
            role: 'pasteAndMatchStyle',
            // accelerator: 'CmdOrCtrl+Shift+V',
        }),
        new MenuItem({
            label: 'Paste as Plain Text',
            // Only enable the menu item for Editable context which supports paste
            visible: parameters.isEditable && parameters.editFlags.canPaste,
            click: () => {
                // Insert the plain text from the clipboard
                const text = clipboard.readText();
                browserWindow.webContents.insertText(text);
            },
            accelerator: 'CmdOrCtrl+Shift+V',
        }),
    ],
});

Please note that the shortcut (accelerator) can be changed as per preference. This solution is straightforward and simple but open to any adjustments as per feedback or testing outcomes.

2023-07-27.20-32-24.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0134ff08ce327769dc

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[kevinksullivan]

Moving forward 👍