Prevent user from visiting archived room setting by hungvu193 · Pull Request #23907 · Expensify/App

hungvu193 · 2023-07-31T05:16:26Z

Details

Prevent user from visiting archived room setting

Fixed Issues

$ #23473
PROPOSAL: #23473 (comment)

Tests

Create a new room
Delete the workspace link to that room
Verify that NotFoundPage will show when user go participant, settings, notification preference, write capability page of that room.

Verify that no errors appear in the JS console

Offline tests

Bug is not related to offline mode itself. No extra steps needed.

QA Steps

Create a new room
Delete the workspace link to that room
Verify that NotFoundPage will show when user go participant, settings, notification preference, write capability page of that room.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots

Web

Screen.Recording.2023-07-31.at.12.19.12.mov

Mobile Web - Chrome

RPReplay_Final1690783474.MP4

Mobile Web - Safari

RPReplay_Final1690783386.MP4

Desktop

Screen.Recording.2023-07-31.at.13.05.45.mov

IOS

Screen.Recording.2023-07-31.at.13.14.57.mov

Android

Screen.Recording.2023-07-31.at.13.16.06.mov

melvin-bot · 2023-07-31T06:17:06Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2023-07-31T06:17:25Z

@robertKozik PR is ready for review! Please have a look. Ty 😄

robertKozik · 2023-07-31T20:03:08Z

Thanks @hungvu193! I'm on it

robertKozik · 2023-07-31T20:03:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.-.web.mov

Mobile Web - Safari

iOS.-.web.mov

Desktop

desktop.mov

iOS

ios.-.native.mov

Android

android.-.native.mov

robertKozik

One question about the WriteCapabilityPage.js, is it covered in test steps?

robertKozik · 2023-08-01T12:14:53Z

+    const isAbleToEdit = !ReportUtils.isAdminRoom(props.report) && PolicyUtils.isPolicyAdmin(props.policy) && !ReportUtils.isArchivedRoom(props.report);



Is this screen covered in test steps?

Thanks for pointing it out! I've just updated the steps!

robertKozik

Test Well, let's push this forward

OSBotify · 2023-08-01T17:12:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-02T01:22:03Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T17:43:16Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T18:14:30Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:31:36Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hungvu193 added 2 commits July 31, 2023 12:15

block user from archived room setting

e724781

update case for title

ae0a516

hungvu193 marked this pull request as ready for review July 31, 2023 06:17

hungvu193 requested a review from a team as a code owner July 31, 2023 06:17

melvin-bot Bot removed the request for review from a team July 31, 2023 06:17

melvin-bot Bot requested a review from robertKozik July 31, 2023 06:17

robertKozik reviewed Aug 1, 2023

View reviewed changes

robertKozik approved these changes Aug 1, 2023

View reviewed changes

melvin-bot Bot requested a review from Li357 August 1, 2023 12:37

Li357 approved these changes Aug 1, 2023

View reviewed changes

Li357 merged commit b8733f4 into Expensify:main Aug 1, 2023

OSBotify mentioned this pull request Aug 1, 2023

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed

79 tasks

hungvu193 mentioned this pull request Aug 2, 2023

[$1000] Web - Still able to access Settings of archived room #23471

Closed

6 tasks

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

melvin-bot Bot mentioned this pull request Aug 3, 2023

[HOLD for payment 2023-08-10] [$1000] Web - Still able to access participants page of archived room - Result in empty page. #23473

Closed

6 tasks

		const isAbleToEdit = !ReportUtils.isAdminRoom(props.report) && PolicyUtils.isPolicyAdmin(props.policy) && !ReportUtils.isArchivedRoom(props.report);

Conversation

hungvu193 commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots

Uh oh!

melvin-bot Bot commented Jul 31, 2023

Uh oh!

hungvu193 commented Jul 31, 2023

Uh oh!

robertKozik commented Jul 31, 2023

Uh oh!

robertKozik commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

robertKozik Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

hungvu193 Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

robertKozik Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 1, 2023

Uh oh!

OSBotify commented Aug 2, 2023

Uh oh!

OSBotify commented Aug 3, 2023

Uh oh!

OSBotify commented Aug 3, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hungvu193 commented Jul 31, 2023 •

edited

Loading

robertKozik commented Jul 31, 2023 •

edited

Loading