Fix inability to mark expenses as billable#89425
Open
x-dev90 wants to merge 1 commit intoExpensify:mainfrom
Open
Fix inability to mark expenses as billable#89425x-dev90 wants to merge 1 commit intoExpensify:mainfrom
x-dev90 wants to merge 1 commit intoExpensify:mainfrom
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
These changes make billable expense behavior consistent across the app by relying on the shared policy-level billable tracking helper instead of checking one raw policy field directly.
The billable field will now appear when billable tracking is actually enabled for the workspace policy, including in expense confirmation and expense detail views. Additionally, when workspace rules are enabled and billable tracking was previously disabled, the app now turns billable tracking back on using the workspace’s existing default billable setting. This helps prevent users from enabling rules while the billable controls remain hidden or out of sync with the policy configuration.
Fixed Issues
$ #88153
PROPOSAL: #88153 (comment)
Tests
Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
REC-2026050233354.AM.mp4
Android: mWeb Chrome
REC-2026050234232.AM.mp4
iOS: Native
REC-2026050234933.AM.mp4
iOS: mWeb Safari
REC-2026050235139.AM.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-05-02.at.3.21.31.AM.mov