feat: factory function 'fromMilliseconds' added#24
Merged
FatulM merged 2 commits intoFatulM:masterfrom Aug 4, 2024
Merged
Conversation
FatulM
requested changes
Jul 31, 2024
Owner
There was a problem hiding this comment.
Hello,
Thanks for this feature ...
Test cases are failing ...
Check that if this failing is not a problem with my library,
please fix the test cases.
And also please use final instead of var in your test cases.
And also since we are providing milliseconds in factory method:
please add test cases for all fields including seconds and milliseconds.
Thanks.
Contributor
Author
|
It was a timezone problem cause of the timezone difference between my laptop and Github server :) Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
By merging this PR users can write shorter code.
Before:
After:
This factory function added to 'Gregorian' class too.
Tests are included in this PR.