Make TreeSitterError inherit Exception

[stackmystack]

We don't want our exceptions to go unnoticed or handled by default rescue.

Consumers need to handle them explicitly.

[DerekStride]

This would be surprising to me as a user of the gem. Why don't we want them to be handled by default rescue blocks?

[stackmystack]

Thanks for replying, I was hoping you'd see it today :)

This would be surprising to me as a user of the gem. Why don't we want them to be handled by default rescue blocks?

Take LoadError for instance. This is not a StandardError. If you look at LanguageLoadError, ParserNotFoundError, and ParserVersionError, at least, these are equivalent to a LoadError. You should absolutely handle them by name. In some sense, they are "unrecoverable" errors.

I would argue that SymbolNotFoundError and QueryCreationError are also similar in nature, in the sense that if you get them, then you're doing something deeply wrong … I will not defend this argument for those 2 errors with my life, but the first 3 are obviously very serious errors IMO. Maybe the strongest argument I can advance for these 2 to be this way is the fact that they inherit TreeSitterError, and treating them differently is a PITA.

I understand that the standard practice is to inherit StandardError, but maybe that applies to applications more than anything. For libraries, that makes me a bit uncomfortable.

WDYT?

[DerekStride]

I would argue that SymbolNotFoundError and QueryCreationError are also similar in nature, in the sense that if you get them, then you're doing something deeply wrong

Hmm, the others make more sense now that you've laid it out. I'm still on the fence about these ones but also don't have strong feelings.

[DerekStride]

This could arguably be a breaking change. I think we should at least bump to v1.10.0 or even v2.0.0.

[stackmystack]

I agree with that. Let's bump to 1.10.0. I prefer bumping major when tree-sitter breaks some APIs, but I'm not religious about that. You prefer 2.0.0?

[DerekStride]

1.10.0 is good with me 👍