De barrelify fix#8
Merged
charle692 merged 2 commits intoFullscript:de-barrelifyfrom Jul 26, 2024
Merged
Conversation
backy22
commented
Jul 5, 2024
| [newSpecifier], | ||
| builder.stringLiteral(finalizedImportSource), | ||
| path.node.importKind | ||
| specifier?.importKind |
Author
There was a problem hiding this comment.
It seems path.node.importKind gets value even when it's type.
Author
There was a problem hiding this comment.
For example, ./src/store/catalogFilters/useUpdateCatalogFilters/useUpdateCatalogFilters.ts
import { useSetCatalogFilters, type Filters, type Filter } from "@store/catalogFilters";
path.node.importKind returns value, specifier?.importKind returns type.
the current js-transform generates this
import { Filter } from "@store/catalogFilters/catalogFilters";
import { Filters } from "@store/catalogFilters/catalogFilters";
import { useSetCatalogFilters } from "@store/catalogFilters/catalogFilters";
but prettier will add type.
Also there are opposite cases too.
path.node.importKind returns type, specifier?.importKind returns value.
So probably this fix isn't right. will revert this fix for now
revert line 112 change
Collaborator
|
This is great Aya, thanks for the change and update :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.