Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the read_with_horizon method to ensemble classes for reading forecast data at specific forecast horizons. The method enables filtering ensemble data based on the lead time from forecast creation to target time.
- Adds
read_with_horizonmethod to Kp and Hp ensemble classes for horizon-based data reading - Refactors file listing logic into separate helper methods for better code organization
- Updates test suites with comprehensive coverage for the new horizon functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| swvo/io/kp/ensemble.py | Implements read_with_horizon method and refactors file listing into ensemble_file_list helper |
| swvo/io/hp/ensemble.py | Adds abstract read_with_horizon method to base class and concrete implementations for Hp30/Hp60 |
| tests/io/kp/test_kp_ensemble.py | Adds comprehensive test cases for Kp ensemble horizon functionality |
| tests/io/hp/test_hp_ensemble.py | Adds test coverage for Hp ensemble horizon methods with validation and error cases |
| tests/io/dst/test_wdc.py | Updates test date to avoid potential data availability issues |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #12