Migrate StructureLib Blood Altar handler from StructureCompat#81
Merged
serenibyss merged 5 commits intomasterfrom May 7, 2025
Merged
Migrate StructureLib Blood Altar handler from StructureCompat#81serenibyss merged 5 commits intomasterfrom
serenibyss merged 5 commits intomasterfrom
Conversation
… to work with the recent addition of having special blocks set to minecraft:air to work with any non-air block.
Member
|
@mitchej123 since you reviewed the other pr maybe you can review this as well ? |
Dream-Master
added
the
🚧 Testing on Zeta
serenibyss
approved these changes
May 7, 2025
Member
serenibyss
left a comment
serenibyss
left a comment
There was a problem hiding this comment.
Looks to retain the previous behavior with some slight improvements, thanks!
serenibyss
removed
the
🚧 Testing on Zeta
DrParadox7
pushed a commit
to DrParadox7/BloodMagic
that referenced
this pull request
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix it to work with #68. Default block to show in the renderer is stone brick, and using a structure hologram will not place anything (but will show the hint dots) and tell the player that they accept any block in chat. Functionality should be equivalent for configs with those blocks set to one specific block (like in GT:NH).