Backport Key Combos

[Caedis]

Will need to add a mod exclusion to https://github.com/GTNewHorizons/Hodgepodge/blob/master/src/main/java/com/mitchej123/hodgepodge/mixins/Mixins.java#L477-L483 (no need to)

added api for other mods to call to set a default modifier for a keybind

tested with gtnhlib's synckeybind via GT's wrench mode on client and server
Note: combos do NOT work inside of guis

api transparency: created with the help of codex

[github-actions]

#9

[lc-1337]

is this works with gtnhlib keybind sync thing?

[Caedis]

@lc-1337 as long as the synced keybind was created with createFromMC or createConfigurable it should work since those are backed by real keybindings. The other way (create with just a keycode) will not since it bypasses what Controlling is doing and just calls Keyboard.isDown directly.

[lc-1337]

damn GTNewHorizons/GTNHLib#237

[mitchej123]

Seems fine - have you tested on lwjgl2 and 3?

[RuiXuqi]

Actually there have been a mod you have noticed, which backports modern key combo system, and it crashes with GTNH Controlling after this PR. Can we maintain compatibility with it, or replace it with full API support, in order not to break existing mods' compatibility?

[Caedis]

Actually there have been a mod you have noticed, which backports modern key combo system, and it crashes with GTNH Controlling after this PR. Can we maintain compatibility with it, or replace it with full API support, in order not to break existing mods' compatibility?

No. This change replaces that mod on every level. Plus that mod is ARR.
There is no reason to have that mod with this change

[RuiXuqi]

Actually there have been a mod you have noticed, which backports modern key combo system, and it crashes with GTNH Controlling after this PR. Can we maintain compatibility with it, or replace it with full API support, in order not to break existing mods' compatibility?

No. This change replaces that mod on every level. Plus that mod is ARR. There is no reason to have that mod with this change

Yea I know Controlling replaces that mod, so I suggest to implement its existing API too, making mods using MKB API can work with Controlling. Sorry my words seemed to lead to confusion.

btw the mod is licensed AGPL(GNU AFFERO GENERAL PUBLIC LICENSE) on CF and the main branch. Their devs just forget to mark it on 1.7.10 branch.

[Caedis]

That is not how licensing works

[RuiXuqi]

That is not how licensing works

OK got it